Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 expose listing license checkouts for frontend #6987

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

🎨 expose listing license checkouts for frontend #6987

wants to merge 12 commits into from

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Dec 20, 2024 •
edited
Loading

@matusdrobuliak66 matusdrobuliak66 self-assigned this Dec 20, 2024
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Dec 20, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Dec 20, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.18182% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.76%. Comparing base (493488c) to head (ad84e9b).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6987      +/-   ##
==========================================
+ Coverage   83.87%   86.76%   +2.88%     
==========================================
  Files        1621     1417     -204     
  Lines       63993    58823    -5170     
  Branches     2035     1645     -390     
==========================================
- Hits        53672    51035    -2637     
+ Misses       9988     7517    -2471     
+ Partials      333      271      -62
Flag Coverage Δ
integrationtests 64.91% <70.65%> (+0.32%) ⬆️
unittests 84.88% <98.18%> (+2.57%) ⬆️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.57% <100.00%> (+0.02%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 73.22% <0.00%> (-0.06%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.38% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.19% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker ∅ <ø> (∅)
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.43% <100.00%> (+10.17%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493488c...ad84e9b. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review December 20, 2024 14:15
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) December 20, 2024 14:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pcrespov
pcrespov approved these changes Jan 3, 2025
View reviewed changes
services/web/server/src/simcore_service_webserver/licenses/_licensed_items_checkouts_api.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We started renaming these as _service instead of _api, rithg?

...ices/web/server/src/simcore_service_webserver/licenses/_licensed_items_checkouts_handlers.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We started renaming these as _rest instead of _handlers

services/web/server/src/simcore_service_webserver/licenses/_licensed_items_purchases_api.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

services/web/server/src/simcore_service_webserver/licenses/_rpc.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting enough you have a single rpc controller for all the subdomains but one rest handler per subdomain. Perhaps you can put all rest handerles in a single rest controller?
I guess if the code is mostly in the repo and service layer, it should be possible and not too bulky

pcrespov
pcrespov reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a badge to show new openapi specs in the description :-)
It is easy and a good practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels
a:webserver issue related to the webserver service
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
4 participants
@matusdrobuliak66 @giancarloromeo @GitHK @pcrespov